-
Notifications
You must be signed in to change notification settings - Fork 730
Add transpose copy #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transpose copy #2556
Conversation
a0f8537 to
d474a96
Compare
|
Hi @metascroy - thank you for your contribution! Would you mind adding a little more detail into your commit message/PR description? I'd love to get the reasoning behind the change recorded in the commit message. |
Added more detail |
|
LGTM! Thanks Scott for adding We might need to block merge until our release is done, @TobyRoseman to confirm |
Thanks @YifanShenSZ! Can you also have a look at the ExecuTorch PR when you get a chance: pytorch/executorch#12648 |
|
CI passed, once @TobyRoseman has finished the release we can land this. |
|
Thanks @metascroy for the pull request. We just did a big release. Please rebase this change on top of tip of main. Then I will kick off a CI run. |
d474a96 to
7d38c01
Compare
Done |
This adds coremltools support for transpose_copy, the copy variant of transpose. Many view ops in coremltools already register the copy variant as an alias, e.g.,
But it looks like for transpose this was missed.