Add unbind_copy alias #2557
Merged
Add unbind_copy alias #2557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @YifanShenSZ |
YifanShenSZ
previously approved these changes
Jul 18, 2025
YifanShenSZ
dismissed
their stale review
We might need to block merge until our release is done, @TobyRoseman to confirm
Collaborator
|
Thanks again, Scott! As Yifan said, we do have to block until the release is done. I've kicked off CI for both PRs and I'll add an update when they pass |
Collaborator
|
CI passed, once @TobyRoseman has finished the release we can land this. |
Collaborator
|
Please rebase this change on top of tip of main. |
metascroy
force-pushed
the
add-unbind-copy
branch
from
c4f697f to
3a8b24b
Compare
Contributor
Author
Done |
Collaborator
YifanShenSZ
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds coremltools support for unbind_copy, the copy variant of unbind. Many view ops in coremltools already register the copy variant as an alias, e.g.,
view: https://github.com/apple/coremltools/blob/main/coremltools/converters/mil/frontend/torch/ops.py#L2316
permute: https://github.com/apple/coremltools/blob/main/coremltools/converters/mil/frontend/torch/ops.py#L1011
But it looks like for unbind this was missed.
Similar PR for transpose_copy: #2556