Update: open side sheet when `many` type relationships #2290

ItzNotABug · 2025-08-31T12:31:48Z

What does this PR do?

Open side sheet when many relations -

Screen.Recording.2025-08-31.at.6.01.08.PM.mov

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

New Features
- Disable inline editing for to‑many relationship cells; these now open in a dedicated side sheet when available.
- Relationship cells in the spreadsheet show a non‑interactive “Items” label with a count badge instead of a clickable element.
- Row editor routing updated so edits for to‑many relationships go through the side‑sheet flow.
Changes
- Integer columns now always enforce min/max clamping (range constraints applied consistently).

appwrite · 2025-08-31T12:31:52Z

Console

Project ID: 688b7bf400350cbd60e9

Sites (2)

Site	Status	Logs	Preview	QR
console-qa `688b7cf6003b1842c9dc`	Ready	View Logs	Preview URL
console-cloud `688b7c18002b9b871a8f`	Ready	View Logs	Preview URL

Note

Cursor pagination performs better than offset pagination when loading further pages.

coderabbitai · 2025-08-31T12:31:55Z

Walkthrough

Adds a boolean prop noInlineEdit (default false) to the cell edit component and early-exits on mount to call openSideSheet when noInlineEdit is true. Changes isRelationshipToMany signature to accept a broader Columns type with runtime guards and a local cast to Models.ColumnRelationship. In the spreadsheet view, to-many relationship cells now display a non-interactive “Items” label with a Badge, introduce openSideSheetForRelationsToMany(tableId, rows) and route to-many edits through that side-sheet; EditRowCell is passed noInlineEdit={isRelationshipToMany(rowColumn)}. Updates inline editor click handler to invoke openSideSheet?.() and unconditionally runs integer min/max clamping reactive logic.

Possibly related PRs

Fix: numbers edits #2286 — modifies the same integer column clamping logic in src/.../rows/columns/types/integer.svelte, related change to min/max reactive behavior.

Suggested reviewers

TorstenDittmann
ChiragAgg5k
eldadfux

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9959953 and eae4abd.

📒 Files selected for processing (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/cell/edit.svelte (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/cell/edit.svelte

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: build
GitHub Check: e2e

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch open-sheet

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte (1)

902-906: Coalesce count to 0; optional: make the to-many chip open the side sheet

row[columnId]?.length can yield undefined; show 0 for clarity.
UX: consider making the “Items” chip clickable to open the row side sheet directly (discoverability), mirroring the to-one behavior.

-                                        {@const itemsNum = row[columnId]?.length}
-                                        Items <Badge
-                                            content={itemsNum}
+                                        {@const itemsNum = Array.isArray(row[columnId]) ? row[columnId].length : 0}
+                                        Items <Badge
+                                            content={itemsNum}
                                             variant="secondary"
                                             size="s" />

Optional click-to-open (if desired):

-                                        Items <Badge
+                                        <Link.Button
+                                            variant="muted"
+                                            on:click={() => {
+                                                $databaseRowSheetOptions.show = true;
+                                                $databaseRowSheetOptions.row = row;
+                                                $databaseRowSheetOptions.title = 'Update row';
+                                            }}>
+                                            Items <Badge
                                                 content={itemsNum}
                                                 variant="secondary"
-                                                size="s" />
+                                                size="s" />
+                                        </Link.Button>

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5731390 and 85c749a.

📒 Files selected for processing (3)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/cell/edit.svelte (2 hunks)
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/store.ts (1 hunks)
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/store.ts (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/store.ts (1)

Columns (9-18)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: build
GitHub Check: e2e

🔇 Additional comments (3)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/store.ts (1)

5-16: Correct child‐side classification implemented
The updated logic now treats only manyToMany as to‐many on the child side and oneToMany / manyToMany on the parent side, which aligns with all downstream usages of isRelationshipToMany.

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/cell/edit.svelte (1)

13-21: Prop addition and typing look good

noInlineEdit?: boolean with default false preserves backward compatibility.

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte (1)

955-961: noInlineEdit binding depends on corrected to-many detection

After fixing isRelationshipToMany child-side logic, this will correctly keep inline editing for many-to-one and route to side sheet for one-to-many/many-to-many.

Please sanity-check:

Parent one-to-many: double-click cell opens row side sheet.

Child many-to-one: inline editor opens as before.

Many-to-many: row side sheet opens.

...project-[region]-[project]/databases/database-[database]/table-[table]/rows/cell/edit.svelte

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte (1)
908-911: Avoid “undefined” badge; default count to 0 (and consider singular/plural later).

If row[columnId] is null, itemsNum is undefined. Default to 0 to prevent odd UI.
-Items <Badge
-    content={itemsNum}
+Items <Badge
+    content={itemsNum ?? 0}
     variant="secondary"
     size="s" />

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 85c749a and 5856c09.

📒 Files selected for processing (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: build
GitHub Check: e2e

🔇 Additional comments (2)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte (2)

961-961: LGTM: Disabling inline edit for to-many via noInlineEdit.

This aligns with the new side-sheet flow and avoids confusing inline editors on collection relationships.

471-475: Refine openSideSheetForRelationsToMany and widen rows type

Rename the first parameter to relatedTableId to avoid shadowing the outer tableId.

Allow rows to be string[] as well as Models.Row[]: update the function signature in spreadsheet.svelte and the rows type in store.ts to string[] | Models.Row[].

...e)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5856c09 and 9959953.

📒 Files selected for processing (2)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/columns/types/integer.svelte (1 hunks)
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

...ion]-[project]/databases/database-[database]/table-[table]/rows/columns/types/integer.svelte

update: open side sheet when many type relationships.

85c749a

ItzNotABug self-assigned this Aug 31, 2025

coderabbitai bot reviewed Aug 31, 2025

View reviewed changes

...project-[region]-[project]/databases/database-[database]/table-[table]/rows/cell/edit.svelte Show resolved Hide resolved

ItzNotABug added 4 commits September 2, 2025 12:59

Merge branch 'main' into open-sheet

c90de13

Merge branch 'main' into open-sheet

b2460ee

update: show correct sidebar.

5856c09

Merge branch 'main' into open-sheet

aa382a8

ItzNotABug marked this pull request as draft September 2, 2025 12:42

coderabbitai bot reviewed Sep 2, 2025

View reviewed changes

...e)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte Show resolved Hide resolved

ItzNotABug added 2 commits September 2, 2025 18:38

Merge branch 'main' into open-sheet

b6a3d8d

fix: edit more in sheet for numbers.

9959953

ItzNotABug marked this pull request as ready for review September 4, 2025 03:57

address: rabbit's comment.

eae4abd

coderabbitai bot reviewed Sep 4, 2025

View reviewed changes

...ion]-[project]/databases/database-[database]/table-[table]/rows/columns/types/integer.svelte Show resolved Hide resolved

HarshMN2345 approved these changes Sep 4, 2025

View reviewed changes

ItzNotABug merged commit 3b61864 into main Sep 4, 2025
5 checks passed

ItzNotABug deleted the open-sheet branch September 4, 2025 04:20

This was referenced Sep 8, 2025

Spatial type attributes #2338

Merged

Accordions when many relation items in sheet #2352

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update: open side sheet when `many` type relationships #2290

Update: open side sheet when `many` type relationships #2290

Uh oh!

ItzNotABug commented Aug 31, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

appwrite bot commented Aug 31, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 31, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Update: open side sheet when many type relationships #2290

Update: open side sheet when many type relationships #2290

Uh oh!

Conversation

ItzNotABug commented Aug 31, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Test Plan

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Summary by CodeRabbit

Uh oh!

appwrite bot commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Console

Uh oh!

coderabbitai bot commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Update: open side sheet when `many` type relationships #2290

Update: open side sheet when `many` type relationships #2290

ItzNotABug commented Aug 31, 2025 •

edited by coderabbitai bot

Loading

appwrite bot commented Aug 31, 2025 •

edited

Loading

coderabbitai bot commented Aug 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)