Skip to content

Update: open side sheet when many type relationships #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 4, 2025
Merged

Update: open side sheet when many type relationships #2290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
85c749a
update: open side sheet when `many` type relationships.
ItzNotABug Aug 31, 2025
c90de13
Merge branch 'main' into open-sheet
ItzNotABug Sep 2, 2025
b2460ee
Merge branch 'main' into open-sheet
ItzNotABug Sep 2, 2025
5856c09
update: show correct sidebar.
ItzNotABug Sep 2, 2025
aa382a8
Merge branch 'main' into open-sheet
ItzNotABug Sep 2, 2025
b6a3d8d
Merge branch 'main' into open-sheet
ItzNotABug Sep 2, 2025
9959953
fix: edit more in sheet for numbers.
ItzNotABug Sep 2, 2025
eae4abd
address: rabbit's comment.
ItzNotABug Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...ject-[region]-[project]/databases/database-[database]/table-[table]/rows/cell/edit.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@
row = $bindable(null),
onChange = null,
onRevert = null,
noInlineEdit = false,
openSideSheet = null,
onRowStructureUpdate = null
}: {
row: Models.Row;
column: Columns;
noInlineEdit?: boolean;
openSideSheet?: () => void;
onChange?: (row: Models.DefaultRow) => void;
onRevert?: (row: Models.DefaultRow) => void;
Expand All @@ -27,6 +29,11 @@
onMount(() => {
original = structuredClone(row);

if (noInlineEdit) {
openSideSheet?.();
return;
}

const trigger = wrapperEl.querySelector('button.input') as HTMLButtonElement;
if (trigger) {
trigger.click();
Expand Down Expand Up @@ -62,5 +69,5 @@
fromSpreadsheet
label={undefined}
bind:formValues={row}
on:click={openSideSheet} />
on:click={() => openSideSheet?.()} />
</div>
2 changes: 1 addition & 1 deletion ...]-[project]/databases/database-[database]/table-[table]/rows/columns/types/integer.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
label = undefined;
}
$: if (limited) {
$: {
column.min = isWithinSafeRange(column.min) ? column.min : Number.MIN_SAFE_INTEGER;
column.max = isWithinSafeRange(column.max) ? column.max : Number.MAX_SAFE_INTEGER;
}
Expand Down
8 changes: 6 additions & 2 deletions ...ole)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@ import { page } from '$app/state';
import type { Columns } from '../store';
import { type Models, Query } from '@appwrite.io/console';

export function isRelationshipToMany(column: Models.ColumnRelationship) {
if (!column) return false;
export function isRelationshipToMany(col: Columns) {
if (!col) return false;
if (!isRelationship(col)) return false;

const column = col as Models.ColumnRelationship;

if (!column?.relationType) return false;
if (column?.side === 'child') {
return !['oneToOne', 'oneToMany'].includes(column?.relationType);
Expand Down
33 changes: 20 additions & 13 deletions ...project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,12 @@
}
}

function openSideSheetForRelationsToMany(tableId: string, rows: string | Models.Row[]) {
$databaseRelatedRowSheetOptions.tableId = tableId;
$databaseRelatedRowSheetOptions.rows = rows;
$databaseRelatedRowSheetOptions.show = true;
}

async function onSelectSheetOption(
action: HeaderCellAction | RowCellAction,
columnId: string,
Expand Down Expand Up @@ -885,18 +891,10 @@
{/if}
{:else}
{@const itemsNum = row[columnId]?.length}
<Button.Button
variant="extra-compact"
disabled={!itemsNum}
badge={itemsNum ?? 0}
on:click={() => {
$databaseRelatedRowSheetOptions.show = true;
$databaseRelatedRowSheetOptions.rows =
row[columnId];
$databaseRelatedRowSheetOptions.tableId = columnId;
}}>
Items
</Button.Button>
Items <Badge
content={itemsNum}
variant="secondary"
size="s" />
{/if}
{:else}
{@const value = row[columnId]}
Expand Down Expand Up @@ -946,11 +944,20 @@
{row}
column={rowColumn}
onRowStructureUpdate={updateRowContents}
noInlineEdit={isRelationshipToMany(rowColumn)}
onChange={(row) => paginatedRows.update(index, row)}
onRevert={(row) => paginatedRows.update(index, row)}
openSideSheet={() => {
close(); /* closes the editor */
onSelectSheetOption('update', null, 'row', row);

if (isRelationshipToMany(rowColumn)) {
openSideSheetForRelationsToMany(
columnId,
row[columnId]
);
} else {
onSelectSheetOption('update', null, 'row', row);
}
}} />
</svelte:fragment>
</Spreadsheet.Cell>
Expand Down