-
Notifications
You must be signed in to change notification settings - Fork 172
support context cancel cause #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, I sincerely apologize for the delayed response. I've fixed the tests in #99. Please rebase your PR against the main branch so we can proceed with the review. Thank you for your patience and contribution! |
…t users using CancelCause
37c4c88 to
912b0c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 90.86% 90.86%
=======================================
Files 2 2
Lines 230 230
=======================================
Hits 209 209
Misses 17 17
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@JaSei hey, sorry for the slow response. rebased. 🙏 |
JaSei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you PR
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [github.com/avast/retry-go/v4](https://github.com/avast/retry-go) | `v4.6.1` -> `v4.7.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>avast/retry-go (github.com/avast/retry-go/v4)</summary> ### [`v4.7.0`](https://github.com/avast/retry-go/releases/tag/v4.7.0) [Compare Source](avast/retry-go@4.6.1...4.7.0) #### What's Changed - support context cancel cause by [@​NivKeidan](https://github.com/NivKeidan) in [#​117](avast/retry-go#117) - Bump github.com/stretchr/testify from 1.10.0 to 1.11.1 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​136](avast/retry-go#136) - Add FullJitterBackoffDelay by [@​amirrezafahimi](https://github.com/amirrezafahimi) in [#​128](avast/retry-go#128) - No delay after final retry on max attempts by [@​StounhandJ](https://github.com/StounhandJ) in [#​129](avast/retry-go#129) - BackOffDelay multiplies attempts from zero by [@​StounhandJ](https://github.com/StounhandJ) in [#​130](avast/retry-go#130) - add Go version 1.25 to test matrix for expanded compatibility testing by [@​JaSei](https://github.com/JaSei) in [#​142](avast/retry-go#142) #### New Contributors - [@​NivKeidan](https://github.com/NivKeidan) made their first contribution in [#​117](avast/retry-go#117) - [@​amirrezafahimi](https://github.com/amirrezafahimi) made their first contribution in [#​128](avast/retry-go#128) - [@​StounhandJ](https://github.com/StounhandJ) made their first contribution in [#​129](avast/retry-go#129) **Full Changelog**: <avast/retry-go@4.6.1...v4.7.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDYuMCIsInVwZGF0ZWRJblZlciI6IjQxLjE0Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJLaW5kL0RlcGVuZGVuY3lVcGRhdGUiLCJydW4tZW5kLXRvLWVuZC10ZXN0cyJdfQ==--> Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1092 Reviewed-by: earl-warren <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
When consumers of
retry-gouse the contextCausefeature (introduced in go 1.20), the Cause error is not being extracted.