-
Notifications
You must be signed in to change notification settings - Fork 172
BackOffDelay multiplies attempts from zero #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
783bdf2 to
6c62c20
Compare
tstromberg
added a commit
to codeGROOVE-dev/retry
that referenced
this pull request
Jul 28, 2025
tstromberg
added a commit
to codeGROOVE-dev/retry
that referenced
this pull request
Jul 28, 2025
merge: BackOffDelay multiplies attempts from zero avast#130
Collaborator
|
Thanks for this PR. I apologize for the delayed response. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
=========================================
- Coverage 90.86% 0 -90.87%
=========================================
Files 2 0 -2
Lines 230 0 -230
=========================================
- Hits 209 0 -209
+ Misses 17 0 -17
+ Partials 4 0 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
project-mirrors-bot-tu bot
pushed a commit
to project-mirrors/forgejo-runner
that referenced
this pull request
Oct 15, 2025
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [github.com/avast/retry-go/v4](https://github.com/avast/retry-go) | `v4.6.1` -> `v4.7.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>avast/retry-go (github.com/avast/retry-go/v4)</summary> ### [`v4.7.0`](https://github.com/avast/retry-go/releases/tag/v4.7.0) [Compare Source](avast/retry-go@4.6.1...4.7.0) #### What's Changed - support context cancel cause by [@​NivKeidan](https://github.com/NivKeidan) in [#​117](avast/retry-go#117) - Bump github.com/stretchr/testify from 1.10.0 to 1.11.1 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​136](avast/retry-go#136) - Add FullJitterBackoffDelay by [@​amirrezafahimi](https://github.com/amirrezafahimi) in [#​128](avast/retry-go#128) - No delay after final retry on max attempts by [@​StounhandJ](https://github.com/StounhandJ) in [#​129](avast/retry-go#129) - BackOffDelay multiplies attempts from zero by [@​StounhandJ](https://github.com/StounhandJ) in [#​130](avast/retry-go#130) - add Go version 1.25 to test matrix for expanded compatibility testing by [@​JaSei](https://github.com/JaSei) in [#​142](avast/retry-go#142) #### New Contributors - [@​NivKeidan](https://github.com/NivKeidan) made their first contribution in [#​117](avast/retry-go#117) - [@​amirrezafahimi](https://github.com/amirrezafahimi) made their first contribution in [#​128](avast/retry-go#128) - [@​StounhandJ](https://github.com/StounhandJ) made their first contribution in [#​129](avast/retry-go#129) **Full Changelog**: <avast/retry-go@4.6.1...v4.7.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDYuMCIsInVwZGF0ZWRJblZlciI6IjQxLjE0Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJLaW5kL0RlcGVuZGVuY3lVcGRhdGUiLCJydW4tZW5kLXRvLWVuZC10ZXN0cyJdfQ==--> Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1092 Reviewed-by: earl-warren <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
mitchnielsen
added a commit
to PrefectHQ/terraform-provider-prefect
that referenced
this pull request
Nov 6, 2025
The retry-go v4.7.0 update in this PR changes how BackOffDelay counts attempts - it now starts from 0 instead of 1, which cuts all retry delays in half. This caused acceptance test failures due to race conditions and API rate limiting (we saw 429 errors in the logs). We now explicitly configure retry delays with a doubled base delay (200ms instead of 100ms) to restore the timing behavior from v4.6.1. This only affects the block schema lookup retry logic. Context: https://github.com/PrefectHQ/terraform-provider-prefect/actions/runs/19077368425 Related: avast/retry-go#130
mitchnielsen
added a commit
to PrefectHQ/terraform-provider-prefect
that referenced
this pull request
Nov 6, 2025
The retry-go v4.7.0 update in this PR changes how BackOffDelay counts attempts - it now starts from 0 instead of 1, which cuts all retry delays in half. This caused acceptance test failures due to race conditions and API rate limiting (we saw 429 errors in the logs). We now explicitly configure retry delays with a doubled base delay (200ms instead of 100ms) to restore the timing behavior from v4.6.1. This only affects the block schema lookup retry logic. Context: https://github.com/PrefectHQ/terraform-provider-prefect/actions/runs/19077368425 Related: avast/retry-go#130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR addresses an issue/127 where the BackOffDelay function incorrectly multiplies the delay duration, not taking into account that the attempt count starts from 1, thus the first delay is initially multiplied twice. In the description for this function, what should increase with the sequence. But in fact, it's a passion from the very first call.
Steps to Reproduce:
Observed Output:
Expected Output: