Skip to content

Conversation

@lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Oct 5, 2022

Issue #, if available:

Description of changes:
Until the integration tests are running consistently successfully in github actions, add a PR template reminder to run the integration tests manually.

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

DataStore checkpoints (check when completed)

  • Ran AWSDataStorePluginIntegrationTests
  • Ran AWSDataStorePluginV2Tests
  • Ran AWSDataStorePluginMultiAuthTests
  • Ran AWSDataStorePluginCPKTests
  • Ran AWSDataStorePluginAuthCognitoTests
  • Ran AWSDataStorePluginAuthIAMTests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

phantumcode
phantumcode previously approved these changes Oct 6, 2022
@lawmicha lawmicha changed the title chore(datastore-v2): update PR template with checkpoints chore(datastore): update PR template with checkpoints Oct 6, 2022
@lawmicha lawmicha marked this pull request as ready for review October 6, 2022 15:32
@lawmicha lawmicha requested review from a team as code owners October 6, 2022 15:32
@lawmicha lawmicha requested a review from phantumcode November 2, 2022 19:01
Copy link
Member

@harsh62 harsh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lawmicha lawmicha merged commit 2151de1 into main Nov 2, 2022
@lawmicha lawmicha deleted the dev-preview-datastore-pr branch November 2, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants