Skip to content

Conversation

@lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Oct 5, 2022

Issue #, if available:

Description of changes:
similar reminder on dev-preview #2393

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha changed the title Update PULL_REQUEST_TEMPLATE.md chore(datastore-v1): update PR template with checkpoints Oct 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #2394 (5f778cd) into main (6672b2a) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
+ Coverage   63.96%   64.01%   +0.04%     
==========================================
  Files         720      720              
  Lines       22633    22633              
==========================================
+ Hits        14478    14489      +11     
+ Misses       8155     8144      -11     
Flag Coverage Δ
API_plugin_unit_test 66.66% <ø> (ø)
AWSPluginsCore 73.30% <ø> (-0.08%) ⬇️
Amplify 51.32% <ø> (+0.05%) ⬆️
Analytics_plugin_unit_test 72.72% <ø> (ø)
Auth_plugin_unit_test 81.94% <ø> (ø)
DataStore_plugin_unit_test 81.63% <ø> (+0.14%) ⬆️
Geo_plugin_unit_test 57.87% <ø> (ø)
Predictions_plugin_unit_test 33.53% <ø> (ø)
Storage_plugin_unit_test 59.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Plugin/Sync/Support/MutationEvent+Extensions.swift 23.80% <0.00%> (-45.24%) ⬇️
...e/AWSPluginsCore/Auth/AWSAuthServiceBehavior.swift 75.00% <0.00%> (-12.50%) ⬇️
...oreCategoryPlugin/Sync/Support/Model+Compare.swift 82.29% <0.00%> (+2.08%) ⬆️
...s/AWSHubPlugin/Internal/HubChannelDispatcher.swift 94.11% <0.00%> (+8.82%) ⬆️
...MutationQueue/OutgoingMutationQueue+Resolver.swift 92.85% <0.00%> (+10.71%) ⬆️
...ngMutationQueue/OutgoingMutationQueue+Action.swift 66.66% <0.00%> (+66.66%) ⬆️
...ingMutationQueue/OutgoingMutationQueue+State.swift 68.75% <0.00%> (+68.75%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

phantumcode
phantumcode previously approved these changes Oct 6, 2022
@lawmicha lawmicha changed the title chore(datastore-v1): update PR template with checkpoints chore(datastore): update PR template with checkpoints Oct 6, 2022
@lawmicha lawmicha marked this pull request as ready for review October 6, 2022 15:32
@lawmicha lawmicha requested review from a team as code owners October 6, 2022 15:32
@lawmicha lawmicha requested a review from phantumcode October 6, 2022 15:32
@atierian atierian changed the base branch from main to v1 October 17, 2022 17:24
Copy link
Member

@harsh62 harsh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lawmicha lawmicha merged commit 1f30ad5 into v1 Nov 2, 2022
@lawmicha lawmicha deleted the lawmicha-patch-1 branch November 2, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants