Skip to content

Conversation

@royjit
Copy link
Contributor

@royjit royjit commented Jun 8, 2023

Issue #

Description

Enable a feature to create custom selection set with only primary key. This will allow mutation happening in other devices with custom selection set to be synced without error in Amplify Swift v1. The logic takes parts from the Amplify Swift v2 PR - #2658

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@royjit royjit marked this pull request as ready for review June 27, 2023 17:19
@royjit royjit requested a review from a team as a code owner June 27, 2023 17:19
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #3016 (6becf66) into v1 (648e4c7) will decrease coverage by 0.01%.
The diff coverage is 82.35%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##               v1    #3016      +/-   ##
==========================================
- Coverage   63.82%   63.82%   -0.01%     
==========================================
  Files         722      722              
  Lines       23142    23181      +39     
==========================================
+ Hits        14771    14795      +24     
- Misses       8371     8386      +15     
Flag Coverage Δ
API_plugin_unit_test 62.90% <ø> (-0.09%) ⬇️
AWSPluginsCore 73.24% <88.60%> (+0.13%) ⬆️
Amplify 51.16% <0.00%> (-0.06%) ⬇️
Analytics_plugin_unit_test 72.58% <ø> (ø)
Auth_plugin_unit_test 83.80% <ø> (ø)
DataStore_plugin_unit_test 81.12% <ø> (ø)
Geo_plugin_unit_test 57.87% <ø> (ø)
Predictions_plugin_unit_test 33.58% <ø> (ø)
Storage_plugin_unit_test 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Model/Internal/Schema/ModelField+Association.swift 43.68% <0.00%> (-2.71%) ⬇️
...re/Model/GraphQLDocument/GraphQLSubscription.swift 81.81% <50.00%> (ø)
.../Model/Decorator/ConflictResolutionDecorator.swift 81.81% <77.41%> (-8.81%) ⬇️
...hQLDocument/ModelBasedGraphQLDocumentBuilder.swift 96.15% <100.00%> (+0.69%) ⬆️
...aphQLRequest/GraphQLRequest+AnyModelWithSync.swift 89.84% <100.00%> (+0.07%) ⬆️
...re/AWSPluginsCore/Model/Support/SelectionSet.swift 98.11% <100.00%> (+0.19%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@royjit royjit force-pushed the royjit.lazyloadsubscription branch from b876461 to ceee2cf Compare June 27, 2023 18:33
@royjit royjit changed the title feat(datastore): Add support for lazy loading subscription fix(datastore): Enable mutation with custom selection set to be synced Jun 27, 2023
@royjit royjit force-pushed the royjit.lazyloadsubscription branch from 6becf66 to 70dce1d Compare June 28, 2023 16:46
@royjit royjit merged commit 2ad710f into v1 Jun 29, 2023
@royjit royjit deleted the royjit.lazyloadsubscription branch June 29, 2023 13:44
@royjit royjit changed the title fix(datastore): Enable mutation with custom selection set to be synced fix(datastore): Enable subscription selection set to contain required fields only Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants