Skip to content

Conversation

@royjit
Copy link
Contributor

@royjit royjit commented Jun 29, 2023

Issue #

Description

Adds test for the logic in this PR - #3016

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@royjit royjit marked this pull request as ready for review June 29, 2023 14:01
@royjit royjit requested a review from a team as a code owner June 29, 2023 14:01
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #3063 (0e7dcf4) into v1 (2ad710f) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##               v1    #3063      +/-   ##
==========================================
- Coverage   63.85%   63.77%   -0.08%     
==========================================
  Files         722      722              
  Lines       23193    23193              
==========================================
- Hits        14809    14791      -18     
- Misses       8384     8402      +18     
Flag Coverage Δ
API_plugin_unit_test 62.98% <ø> (ø)
AWSPluginsCore 73.62% <ø> (+0.41%) ⬆️
Amplify 51.17% <ø> (ø)
Analytics_plugin_unit_test 72.58% <ø> (ø)
Auth_plugin_unit_test 83.80% <ø> (ø)
DataStore_plugin_unit_test 80.77% <ø> (-0.39%) ⬇️
Geo_plugin_unit_test 57.87% <ø> (ø)
Predictions_plugin_unit_test 33.58% <ø> (ø)
Storage_plugin_unit_test 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@royjit royjit merged commit b1fbf5a into v1 Jun 29, 2023
@royjit royjit deleted the royjit.testselectionset branch June 29, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants