-
Notifications
You must be signed in to change notification settings - Fork 1.2k
added challenge question for user to retrieve the elb URL #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
58c5c4f
d5097ef
146c6be
d490e3a
3c95cf4
6ea5e05
3e05da7
bb010e6
fcb3f6a
172990c
bf439eb
b83312a
7d41d70
781e875
978bff1
6ded661
e7b3820
c6bafee
08e73ea
d38a893
93d6ff4
cfafc6d
9ae013c
fda5fbb
6c38f5b
6326204
88222ec
9b342ab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ Click the **Launch** button to create the CloudFormation stack in the AWS Manage | |
|
|
||
| | Launch template | | | | ||
| | ------ |:------:|:--------:| | ||
| | CodePipeline & EKS | {{% cf-launch "ci-cd-codepipeline.cfn.yml" "eksws-codepipeline" %}} | {{% cf-download "ci-cd-codepipeline.cfn.yml" %}} | | ||
| | CodePipeline & EKS | {{% cf-launch "eksws-codepipeline" "ci-cd-codepipeline.cfn.yml" %}} | {{% cf-download "ci-cd-codepipeline.cfn.yml" %}} | | ||
vjsikha marked this conversation as resolved.
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure if this also needs to be reverted since reverting the commit in cf-launch? |
||
|
|
||
| After the console is open, enter your GitHub username, personal access token (created in previous step), check the acknowledge box and then click the "Create stack" button located at the bottom of the page. | ||
|
|
||
|
|
@@ -67,6 +67,3 @@ This service was configured with a [LoadBalancer](https://kubernetes.io/docs/tas | |
| an [AWS Elastic Load Balancer](https://aws.amazon.com/elasticloadbalancing/) is launched by Kubernetes for the service. | ||
| The EXTERNAL-IP column contains a value that ends with "elb.amazonaws.com" - the full value is the DNS address. | ||
| {{% /notice %}} | ||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <a | ||
| href="https://console.aws.amazon.com/cloudformation/home?#/stacks/quickcreate?stackName={{ .Get 1 }}&templateURL=https://s3.amazonaws.com/{{ $.Site.Params.template_bucket }}/templates/{{ $.Site.Params.branch }}/{{ .Get 0 }}" | ||
| href="https://console.aws.amazon.com/cloudformation/home?#/stacks/create/review?stackName={{ .Get 0 }}&templateURL=https://s3.amazonaws.com/{{ $.Site.Params.template_bucket }}/templates/{{ $.Site.Params.branch }}/{{ .Get 1 }}" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this file is part of an earlier version of the codebase, and this diff is reverting back to the older version. Please remove it from this PR.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agreed. confirmed that it's an issue when user is on old version of Cloud Formation console. We will convey that all users must be on the newer version. reverting these changes |
||
| target="_blank" class="btn btn-default"> | ||
| <i class="fas fa-cloud-upload-alt"></i> | ||
| Launch | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.