Simplify the Kyber prefix build #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is the repeated |
Contributor
Author
They are not intended, let me check the before. |
andrewhop
force-pushed
the
prefix_everything
branch
from
5a7049c to
682cc9e
Compare
torben-hansen
approved these changes
Aug 4, 2023
dkostic
approved these changes
Aug 8, 2023
skmcgrail
pushed a commit
to skmcgrail/aws-lc
that referenced
this pull request
Sep 14, 2023
Use the same symbol prefixing process as the rest of AWS-LC. This does not change how s2n-bignum gets handled. (cherry picked from commit 754a124)
skmcgrail
added a commit
that referenced
this pull request
Sep 14, 2023
* Simplify the Kyber prefix build (#1131) Use the same symbol prefixing process as the rest of AWS-LC. This does not change how s2n-bignum gets handled. (cherry picked from commit 754a124) * Simplify Prefix Build Support (#1178) (cherry picked from commit ebe0892) * Add prefix symbols for Windows FIPS Shared Build (#1191) (cherry picked from commit 195441d) --------- Co-authored-by: Andrew Hopkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses CryptoAlg-1976
Description of changes:
The prefix build automatically finds symbols to prefix and adds them to
boringssl_prefix_symbols.h, this change updates Kyber to follow that happy path instead of manually constructing the prefix mapping.Call-outs:
This shouldn't have any behavior change.
Testing:
Built the static and shared library and looked at the symbols:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.