Simplify Prefix Build Support #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
reviewed
Sep 11, 2023
skmcgrail
force-pushed
the
prefix-build
branch
2 times, most recently
from
373c387 to
90dd56f
Compare
skmcgrail
force-pushed
the
prefix-build
branch
2 times, most recently
from
e019226 to
d40b2b5
Compare
skmcgrail
force-pushed
the
prefix-build
branch
from
d40b2b5 to
434e0a7
Compare
Member
Author
|
A note for reviewers: aws-lc-rs CI item is expected to fail given the changes here. We will have to update aws-lc-rs after this is merged in. |
justsmth
previously approved these changes
Sep 13, 2023
samuel40791765
previously approved these changes
Sep 13, 2023
skmcgrail
dismissed stale reviews from samuel40791765 and justsmth
via
23889bf
justsmth
approved these changes
Sep 13, 2023
samuel40791765
approved these changes
Sep 13, 2023
skmcgrail
added a commit
to skmcgrail/aws-lc
that referenced
this pull request
Sep 14, 2023
(cherry picked from commit ebe0892)
skmcgrail
added a commit
that referenced
this pull request
Sep 14, 2023
* Simplify the Kyber prefix build (#1131) Use the same symbol prefixing process as the rest of AWS-LC. This does not change how s2n-bignum gets handled. (cherry picked from commit 754a124) * Simplify Prefix Build Support (#1178) (cherry picked from commit ebe0892) * Add prefix symbols for Windows FIPS Shared Build (#1191) (cherry picked from commit 195441d) --------- Co-authored-by: Andrew Hopkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses CryptoAlg-1976
Description of changes:
boringssl_prefix_symbols.h,boringssl_prefix_symbols_asm.h, andboringssl_prefix_symbols_nasm.inchave been relocated toopenssl/boringssl_prefix_symbols_nasm.h,openssl/boringssl_prefix_symbols_asm.h, andopenssl/boringssl_prefix_symbols_nasm.increspectively.include/openssldirectory of the repository, these will be installed bycmake --install <build folder>if a prefix build was not performed.BORINGSSL_PREFIXdefine is now embedded into the generated prefix headers, so the user is no longer required to provide it when linking to an aws-lc installation that was built with a prefix.#includedirectives for the prefix headers have been removed, as the files will always be present as either the empty stubs or the generated content.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.