[release-3.9][DFSM]Using .login_nodes_keys_sync_file to be used during Init and Update phase of the clusters #2677
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-3.9 #2677 +/- ##
============================================
Coverage 76.48% 76.48%
============================================
Files 22 22
Lines 2220 2220
============================================
Hits 1698 1698
Misses 522 522
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
himani2411
changed the title
himani2411
force-pushed
the
wip/release-3.9
branch
from
6581944 to
4a516c2
Compare
gmarciani
reviewed
Mar 5, 2024
| default['cluster']['scheduler_queue_name'] = nil | ||
|
|
||
| default['cluster']['head_node_home_path'] = '/home' | ||
| default['cluster']['shared_dir_compute'] = node['cluster']['shared_dir'] |
Contributor
There was a problem hiding this comment.
himani2411
force-pushed
the
wip/release-3.9
branch
from
4a516c2 to
cfaa6b3
Compare
gmarciani
reviewed
Mar 5, 2024
| code "[[ \"$(cat #{path})\" == \"#{cluster_config_version}\" ]] || exit 1" | ||
| Chef::Log.info("Wait for synchronization file at #{path} to exist") | ||
| file path do | ||
| action :touch |
Contributor
There was a problem hiding this comment.
is the touch action expected to fail if the file does not exist?
Asking because the Linux touch command succeeds even if file do not exist.
If it fails on non existance then we are good
himani2411
force-pushed
the
wip/release-3.9
branch
2 times, most recently
from
f3e162d to
3a36bf7
Compare
| bash "Wait for synchronization file at #{path} to be written for version #{cluster_config_version}" do | ||
| code "[[ \"$(cat #{path})\" == \"#{cluster_config_version}\" ]] || exit 1" | ||
| bash "Wait for synchronization file at #{path} to exist" do | ||
| code "[[ -e #{path} ]]; echo $? || exit 1" |
Contributor
There was a problem hiding this comment.
Minor: Can we do:
code "[[ -e #{path} ]] || exit 1"
hanwen-pcluste
previously approved these changes
Mar 5, 2024
…date phase of the clusters
himani2411
force-pushed
the
wip/release-3.9
branch
from
3a36bf7 to
d4826a2
Compare
hanwen-pcluste
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
[DFSM]Using .login_nodes_keys_sync_file to be used during Init and Update phase of the clusters
Bug:
Introduced in #2671 and #2672
The file we create
/opt/parallelcluster/shared_login_nodes/.login_nodes_keys_sync_fileas part of sync during cluster never gets updated when we Stop-Start the Cluster.This file needs to be updated or any new Login Nodes which are launched after update of the Cluster, goes through the Init phase and wait for the content to be the latest.
Tests
develop #2678
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.