[DFSM]Using .login_nodes_keys_sync_file to be used during Init and Update phase of the clusters

[himani2411]

Description of changes

[DFSM]Using .login_nodes_keys_sync_file to be used during Init and Update phase of the clusters

Bug:
Introduced in #2671 and #2672

The file we create /opt/parallelcluster/shared_login_nodes/.login_nodes_keys_sync_file as part of sync during cluster never gets updated when we Stop-Start the Cluster.
This file needs to be updated or any new Login Nodes which are launched after update of the Cluster, goes through the Init phase and wait for the content to be the latest.

Tests

• Unit Tests
• test_create_disable_sudo_access_for_default_user and test_dynamic_file_systems_update [ONGOING]

develop #2677

References

• Link to impacted open issues.
• Link to related PRs in other packages (i.e. cookbook, node).
• Link to documentation useful to understand the changes.

Checklist

• Make sure you are pointing to the right branch.
• If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
• Check all commits' messages are clear, describing what and why vs how.
• Make sure to have added unit tests or integration tests to cover the new/modified code.
• Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (4f649ee) to head (27a0e47).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2678   +/-   ##
========================================
  Coverage    76.48%   76.48%           
========================================
  Files           22       22           
  Lines         2220     2220           
========================================
  Hits          1698     1698           
  Misses         522      522           

Flag	Coverage Δ
unittests	76.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gmarciani]

thank yo for adding this attribute!

[gmarciani]

This fix would address the issue, but we should do something easier: in this sync file we should not even check the cluster config version at all because it's enough for it to be there to signal that the head node already created the keys. In the offending PRs we included the check of the cluster config version to replicate an approach that was equivalent to the sync file used by the head node to signal changes in the config file. In this case though, the check of the cluster config version is redudant and can be avoided.