chore(codegen): remove deprecated s3 customization #6005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
approved these changes
Apr 15, 2024
trivikr
approved these changes
Apr 15, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
1
The "s3-hack" was a customization that applied model preprocessing during the build of the S3 client.
It formerly did two things:
RuleSetAuthSchemesSmithy suppression that was missing from the modelThe former is now included in the model itself, and the latter has been converted to Java codegen in #5963.
2
The
runtime-dependency-version-check/runtime-dep-version-checkhas also been moved to the end of the code generation script. This ensures unexpected code generation output that is inconsistent with the repository state is blocked from releasing.