Skip to content

chore(codegen): remove deprecated s3 customization #6005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged

chore(codegen): remove deprecated s3 customization #6005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions scripts/generate-clients/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ const { prettifyCode } = require("./code-prettify");
const { eslintFixCode } = require("./code-eslint-fix");
const { buildSmithyTypeScript } = require("./build-smithy-typescript");
const { SMITHY_TS_COMMIT } = require("./config");
const s3Hack = require("./s3-hack");

const SMITHY_TS_DIR = path.normalize(path.join(__dirname, "..", "..", "..", "smithy-typescript"));
const SDK_CLIENTS_DIR = path.normalize(path.join(__dirname, "..", "..", "clients"));
Expand Down Expand Up @@ -77,7 +76,6 @@ const {

(async () => {
try {
require("../runtime-dependency-version-check/runtime-dep-version-check");
if (!noSmithyCheckout) {
await buildSmithyTypeScript(repo, commit);
}
Expand All @@ -97,14 +95,7 @@ const {
}

if (!protocolTestsOnly) {
const undoS3 = s3Hack();
try {
await generateClients(models || globs || DEFAULT_CODE_GEN_INPUT_DIR, batchSize);
undoS3();
} catch (e) {
undoS3();
throw e;
}
await generateClients(models || globs || DEFAULT_CODE_GEN_INPUT_DIR, batchSize);
}

if (!noPrivateClients) {
Expand Down Expand Up @@ -148,6 +139,7 @@ const {
}

require("./customizations/workspaces-thin-client")();
require("../runtime-dependency-version-check/runtime-dep-version-check");
} catch (e) {
console.log(e);
process.exit(1);
Expand Down
31 changes: 0 additions & 31 deletions scripts/generate-clients/s3-hack.js
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions scripts/generate-clients/single-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ const { generateClient } = require("./code-gen");
const { codeOrdering } = require("./code-ordering");
const { copyToClients } = require("./copy-to-clients");
const { spawnProcess } = require("../utils/spawn-process");
const s3Hack = require("./s3-hack");

const SDK_CLIENTS_DIR = normalize(join(__dirname, "..", "..", "clients"));

Expand All @@ -15,14 +14,7 @@ const { solo } = yargs(process.argv.slice(2))

(async () => {
try {
let afterGenerate = () => {};
if (solo === "s3") {
afterGenerate = s3Hack();
}
await generateClient(solo);
if (solo === "s3") {
afterGenerate();
}
await copyToClients(
normalize(join(__dirname, "..", "..", "codegen", "sdk-codegen", "build-single", solo)),
SDK_CLIENTS_DIR,
Expand Down