Skip to content

fix: CI changes #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2022
Merged

fix: CI changes #234

merged 1 commit into from
Jul 8, 2022

Conversation

@satishpasumarthi
Copy link
Contributor

@satishpasumarthi satishpasumarthi commented Jul 8, 2022 •
edited
Loading

Issue #, if available:
The CI is currently broken.

Description of changes:

  • Disable DLC Image creation as it is taken care in other pipelines
  • Remove old unused DFs
  • Update documentation to include correct github links
  • Update requires package for sagemaker-training as the latest v4.2.0 includes Heterogeneous cluster changes.
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-pr
  • Commit ID: c12135c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-toolkit-pr
  • Commit ID: c12135c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-gpu-tests
  • Commit ID: c12135c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-unit-tests
  • Commit ID: c12135c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-pr
  • Commit ID: 1cedec8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-toolkit-pr
  • Commit ID: 1cedec8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-unit-tests
  • Commit ID: 1cedec8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-gpu-tests
  • Commit ID: 1cedec8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-pr
  • Commit ID: 9475cee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-gpu-tests
  • Commit ID: 9475cee
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-toolkit-pr
  • Commit ID: 9475cee
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-unit-tests
  • Commit ID: 9475cee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-pr
  • Commit ID: 10e3e83
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-gpu-tests
  • Commit ID: 10e3e83
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-unit-tests
  • Commit ID: 10e3e83
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-pr
  • Commit ID: 4df5af9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-unit-tests
  • Commit ID: 4df5af9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-gpu-tests
  • Commit ID: 4df5af9
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-pr
  • Commit ID: 30afe17
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-gpu-tests
  • Commit ID: 30afe17
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-unit-tests
  • Commit ID: 30afe17
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-pr
  • Commit ID: 6a21484
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-toolkit-pr
  • Commit ID: 6a21484
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-gpu-tests
  • Commit ID: 6a21484
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-unit-tests
  • Commit ID: 6a21484
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-gpu-tests
  • Commit ID: c618052
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-toolkit-pr
  • Commit ID: c618052
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nish21
nish21 approved these changes Jul 8, 2022
View reviewed changes
Copy link

@nish21 nish21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

buildspec-gputests.yml
- python3 setup.py sdist
- build_dir="test/container/$FRAMEWORK_VERSION"
- $(aws ecr get-login --registry-ids $DLC_ACCOUNT --no-include-email --region $AWS_DEFAULT_REGION)
- build_cmd="docker build -f "$build_dir/Dockerfile.dlc.gpu" -t $PREPROD_IMAGE:$DLC_GPU_TAG --build-arg region=$AWS_DEFAULT_REGION ."
Copy link

@nish21 nish21 Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all of these lines are not required, can we just remove them?

Copy link
Contributor Author

@satishpasumarthi satishpasumarthi Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests will be revisited at a later point of time. Hence wanted to retain the original content

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-unit-tests
  • Commit ID: c618052
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-pytorch-training-container-pr
  • Commit ID: c618052
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@satishpasumarthi satishpasumarthi merged commit 3ad90d1 into aws:master Jul 8, 2022
satishpasumarthi added a commit to satishpasumarthi/sagemaker-pytorch-training-toolkit that referenced this pull request Jul 8, 2022
@satishpasumarthi
fix: CI (aws#234)
68ae426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nish21 nish21 nish21 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@satishpasumarthi @sagemaker-bot @nish21