use Name on node when loading a gltf file #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
reviewed
Jan 1, 2021
examples/3d/load_gltf.rs
Outdated
| } | ||
|
|
||
| // When pressing spacebar, it will display only part of the model, rotating between the parts | ||
| fn display_only_parts( |
Member
There was a problem hiding this comment.
While I like that this shows how to select based on name and running the app is fun, I'm a little hesitant to include it:
- Its a slightly roundabout way to "hide" things. Im assuming we can't use Visible::is_visible because the named nodes are "parents" that we don't actually draw. But toggling visibility would be a bit more self-documenting / idiomatic. As-is its hard to say that this is how people should solve the "hide by name" problem generically.
- It makes the example less minimal. In general I want each example to be a small and clear illustration of a single feature.
Member
Author
There was a problem hiding this comment.
yeah I agree but it was fun to play with... that's why I did it in a different commit, to be extra easy to remove...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #1020, use
Nameinstead ofLabelsalso added
Nameto the prelude, and updated an example showing how to use it for a gltf file