Skip to content

Change default tonemapping method #8685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2023
Merged

Change default tonemapping method #8685

merged 1 commit into from
May 29, 2023

Conversation

@JMS55
Copy link
Contributor

@JMS55 JMS55 commented May 26, 2023

Change the default tonemapping method from ReinhardLuminance to TonyMcMapface, which generally looks nicer and works out of the box with bloom.

Changelog

  • TonyMcMapface is now the default tonemapper, instead of ReinhardLuminance.

Migration Guide

  • The default tonemapper has been changed from ReinhardLuminance to TonyMcMapface. Explicitly set ReinhardLuminance on your cameras to get back the previous look.

@JMS55 JMS55 added the A-Rendering Drawing game state to the screen label May 26, 2023
@JMS55 JMS55 added this to the 0.11 milestone May 26, 2023
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels May 26, 2023
@alice-i-cecile alice-i-cecile requested a review from superdump May 26, 2023 03:32
nicopap
nicopap approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TonyMcMapface is the better one.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 26, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 29, 2023
Merged via the queue into bevyengine:main with commit c8deedb May 29, 2023
@ameknite ameknite mentioned this pull request Jun 5, 2023
Merged
alice-i-cecile pushed a commit that referenced this pull request Jun 5, 2023
@ameknite
Change Camera3dBundle::tonemapping to Default (#8753)
94dce09 
# Objective

- Continue with #8685 to make `TonyMcMapface` the default tonemapping

## Solution

- Change the default value `Camera3dBundle::tonemapping` from
`Tonemapping::ReinhardLuminance` to `Default::default()`
(`Tonemapping::TonyMcMapface`)
This was referenced Jun 28, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@superdump superdump Awaiting requested review from superdump

+1 more reviewer

@nicopap nicopap nicopap approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.11

Development

Successfully merging this pull request may close these issues.

3 participants

@JMS55 @alice-i-cecile @nicopap