Skip to content

Conversation

carlosramireziii
Copy link
Contributor

The Bitbucket::Repos::Changesets#list action was using the parameters from the GitHub API instead of Bitbucket API (see the Bitbucket API documentation for details).

No testing suite is included with the project source code, so I was unable to write any tests to validate the changes. I did manually test it however.

vongrippen added a commit that referenced this pull request Sep 10, 2012
Fix parameters for repository changeset list action
@vongrippen vongrippen merged commit 4c3f5af into bitbucket-rest-api:master Sep 10, 2012
@vongrippen
Copy link
Member

Looks good. Test suite is coming soon, just got snowed under elsewhere.

wkj pushed a commit to solanolabs/bitbucket that referenced this pull request Jul 13, 2016
Closes bitbucket-rest-api#1

LGTM given by: @nhance, @Potherca

Squashed commit of the following:

commit 36e5045479cd676ad3f892bfb3d1c3a8d58e5ec1
Author: Valentino <[email protected]>
Date:   Wed Feb 4 12:14:34 2015 -0500

    Don't use gemsets

commit f1f7fc87cfd621195eb305f8e0e6adca3eab4cb4
Author: Valentino <[email protected]>
Date:   Wed Feb 4 12:13:42 2015 -0500

    Fix fetching all pull requests with overrides

commit 7236a90ab129117f99e869f1eb405f007fed3675
Author: Valentino <[email protected]>
Date:   Tue Feb 3 17:01:02 2015 -0500

    WIP - Initial pagination and updates to api

commit 1b04250c8fd53de82c22390f7be6c24da3225a8b
Author: Valentino <[email protected]>
Date:   Tue Oct 21 17:06:58 2014 -0400

    WIP - major overhaul to upgrade to latest refactorings from the github_api gem for nested resources and pagination

commit 55a8397d880694c9da404a03e5503822601fb1db
Author: Valentino Stoll <[email protected]>
Date:   Mon Oct 20 17:05:35 2014 -0400

    WIP - more honing of paginated api results

commit 51e187155e5d384bad09f80497bea923c7032d90
Author: Valentino Stoll <[email protected]>
Date:   Mon Oct 20 13:50:03 2014 -0400

    WIP - pagination

commit 3a28bd473eb60342dc5d28de3b1ae900efa3f2fb
Author: Valentino <[email protected]>
Date:   Fri Oct 17 16:02:58 2014 -0400

    WIP - initial pagination additions

commit 4c387d47cb6268168e6cb5530d9a69497cc8f769
Author: Valentino <[email protected]>
Date:   Thu Oct 16 17:00:58 2014 -0400

    Update use of 2.0 API for pull requests

commit 3cdfe82a4d2d9166bf3a5035b31d2844c180deaf
Author: Valentino <[email protected]>
Date:   Thu Oct 16 16:00:40 2014 -0400

    Upgrade version of api in endpoint and add pull request resource
ibrahima pushed a commit to gradescope/bitbucket that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants