Skip to content

Fix parameters for repository changeset list action #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2012
Merged

Fix parameters for repository changeset list action #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/bitbucket_rest_api/repos/changesets.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@ class Repos::Changesets < API
# List changesets on a repository
#
# = Parameters
# * <tt>:sha</tt> Optional string. Sha or branch to start listing changesets from.
# * <tt>:path</tt> Optional string. Only changesets containing this file path will be returned
# * <tt>:limit</tt> Optional integer. An integer representing how many changesets to return. You can specify a limit between 0 and 50.
# * <tt>:start</tt> Optional string. A hash value representing the earliest node to start with.
#
# = Examples
# bitbucket = BitBucket.new
# bitbucket.repos.changesets.list 'user-name', 'repo-name', :sha => '...'
# bitbucket.repos.changesets.list 'user-name', 'repo-name', :sha => '...' { |changeset| ... }
# bitbucket.repos.changesets.list 'user-name', 'repo-name', :start => '...'
# bitbucket.repos.changesets.list 'user-name', 'repo-name', :start => '...' { |changeset| ... }
#
def list(user_name, repo_name, params={})
_update_user_repo_params(user_name, repo_name)
_validate_user_repo_params(user, repo) unless user? && repo?
normalize! params
filter! %w[ sha path], params
filter! %w[ limit start], params

response = get_request("/repositories/#{user}/#{repo}/changesets", params)
return response unless block_given?
Expand Down