Clean up compute_coverage_stats, change it to use agg_by_strata and have an optional group_membership_ht parameter
#660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnomad_methods into jg/clean_up_coverage_code
… into jg/clean_up_coverage_code
jkgoodrich
changed the title
compute_coverage_stats and change to use agg_by_strata and have an optional group_membership_ht parametercompute_coverage_stats, change it to use agg_by_strata and have an optional group_membership_ht parameter
mike-w-wilson
approved these changes
Jan 17, 2024
Co-authored-by: Mike Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following notebook was used for testing: http://localhost:8123/notebooks/gnomad-julia/gnomad_v4/test_v4_coverage_function_cleanup.ipynb