Fix about:XXX support in Firefox

[max-baz]

An alternative to #192

Fixes #191

[erayd]

Looks good. We may need a validity check to prevent invalid.invalid from displaying in the anti-phishing filter; normally on an about: page we want to see the entire store.

[max-baz]

@erayd I'll try to resolve conflicts later today, let's finalize this pr and release a new version, with updated deps and these Firefox fixes?

[erayd]

Sounds good :-).

[max-baz]

Looks good. We may need a validity check to prevent invalid.invalid from displaying in the anti-phishing filter; normally on an about: page we want to see the entire store.

Just checked, Chrome parses URLs like chrome://extensions successfully, and Firefox parses URLs like about:addons successfully as well, neither produce invalid.invalid (what will produce invalid.invalid is for example parsing chrome://extension in Firefox).

In other words, when things are normal, users should never see invalid.invalid, even on internal browser pages. Should we just leave this as it is for now? I'm not sure anyway what's the best way of handling invalid urls at the moment, e.g. when a fill request was issued...

[erayd]

I'm happy with this, but if invalid.invalid ever actually shows up in a real-world scenario, then I think we will need to fix it. It's a bit of a rough edge to expose to users. However, if they never see it, then I don't think we need to worry about it.