Skip to content

Fix about:XXX support in Firefox #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2020
Merged

Fix about:XXX support in Firefox #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ async function updateMatchingPasswordsCount(tabId, forceRefresh = false) {

try {
const tab = await chrome.tabs.get(tabId);
badgeCache.settings.origin = new URL(tab.url).origin;
badgeCache.settings.origin = new BrowserpassURL(tab.url).origin;
} catch (e) {
throw new Error(`Unable to determine domain of the tab with id ${tabId}`);
}
Expand Down Expand Up @@ -395,7 +395,7 @@ async function fillFields(settings, login, fields) {

// build fill request
var fillRequest = {
origin: new URL(settings.tab.url).origin,
origin: new BrowserpassURL(settings.tab.url).origin,
login: login,
fields: fields
};
Expand Down Expand Up @@ -482,7 +482,7 @@ async function fillFields(settings, login, fields) {

// build focus or submit request
let focusOrSubmitRequest = {
origin: new URL(settings.tab.url).origin,
origin: new BrowserpassURL(settings.tab.url).origin,
autoSubmit: getSetting("autoSubmit", login, settings),
filledFields: filledFields
};
Expand Down
2 changes: 1 addition & 1 deletion src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
}
],
"dependencies": {
"@browserpass/url": "^1.1.3",
"@browserpass/url": "^1.1.6",
"chrome-extension-async": "^3.3.2",
"fuzzysort": "^1.1.4",
"idb": "^4.0.3",
Expand Down
3 changes: 2 additions & 1 deletion src/popup/searchinterface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module.exports = SearchInterface;

const BrowserpassURL = require("@browserpass/url");
const m = require("mithril");

/**
Expand Down Expand Up @@ -29,7 +30,7 @@ function SearchInterface(popup) {
*/
function view(ctl, params) {
var self = this;
var host = new URL(this.popup.settings.origin).host;
var host = new BrowserpassURL(this.popup.settings.origin).host;
return m(
"form.part.search",
{
Expand Down
2 changes: 1 addition & 1 deletion src/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# yarn lockfile v1


"@browserpass/url@^1.1.3":
"@browserpass/url@^1.1.6":
version "1.1.6"
resolved "https://registry.yarnpkg.com/@browserpass/url/-/url-1.1.6.tgz#53831fe9228ecfba2fec5d0166f3fcbd266e2615"
integrity sha512-mWgr6kco+PFn0+e1cYEmNj0r352eFau5aJRhTR8uHT2D5PYa2KH7dGqkg+uhwkR042etOrPczvaO+5Mp80b0GQ==
Expand Down