Skip to content

fix: Make the application of an ulimit to open fds configurable. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: Make the application of an ulimit to open fds configurable. #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d885c60
fix: Make the application of an ulimit to open fds configurable.
andreas-kupries May 8, 2020
3bc3b59
Addressed comments.
andreas-kupries Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jobs/cc_uploader/spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,7 @@ properties:
description: "PEM-encoded certificate for secure, mutually authenticated TLS communication"
capi.cc_uploader.mutual_tls.server_key:
description: "PEM-encoded key for secure, mutually authenticated TLS communication"

capi.cc_uploader.set_ulimit_fds:
description: "Set an ulimit on the number of open file descriptors. NOTE: set this property to 'false' when deploying to a containerized cloud"
default: true
2 changes: 2 additions & 0 deletions jobs/cc_uploader/templates/cc_uploader_ctl.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ case $1 in
echo 1 > /proc/sys/net/ipv4/tcp_tw_reuse
fi

<% if p("capi.cc_uploader.set_ulimit_fds") %>
# Allowed number of open file descriptors
ulimit -n 100000
<% end %>

# Work around for GOLANG 1.5.3 DNS bug
export GODEBUG=netdns=cgo
Expand Down
4 changes: 4 additions & 0 deletions jobs/cloud_controller_ng/spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,10 @@ properties:
cc.jobs.droplet_upload.timeout_in_seconds:
description: "The longest this job can take before it is cancelled"

cc.set_ulimit_fds:
description: "Set an ulimit on the number of open file descriptors. NOTE: set this property to 'false' when deploying to a containerized cloud"
default: true

cc.temporary_disable_deployments:
description: "Do not allow the API client to create app deployments (temporary)"
default: false
Expand Down
2 changes: 2 additions & 0 deletions jobs/cloud_controller_ng/templates/cloud_controller_api_ctl.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ case $1 in
start)
setup_environment

<% if p("cc.set_ulimit_fds") %>
ulimit -c unlimited
<% end %>

pid_guard "$PIDFILE" "Cloud controller ng"

Expand Down