Update Kevin Markwardt to approver #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on meeting requirements as defined in https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0006-approver-requirements.md Reference previous PR cloudfoundry#426 PR's increased to meet threshold of 20 PXC Release - 13 MySQL Monitoring Release - 4 CF Deployment - 1 Switchboard - 1 CLI Plugin - 1 Total = 20 Authored-by: Kevin Markwardt <[email protected]>
Contributor
Author
Member
|
Hi @kmarkwardt-vmware , there is slide change in the promotion rules. You need two approvals from the approvers in the |
abg
reviewed
Oct 15, 2023
| reviewers: | ||
| - name: Kevin Markwardt | ||
| github: kmarkwardt-vmware | ||
| reviewers: |
Member
There was a problem hiding this comment.
Check is failing:
Failed validating 'type' in schema['properties']['areas']['items']['properties']['reviewers']:
{'items': {'$ref': '#/$defs/githubUser'}, 'type': 'array'}
You probably want to make this an array. e.g. reviewers: []
Contributor
Author
There was a problem hiding this comment.
Thanks for the update, I missed that. All fixed now. Thanks
Authored-by: Kevin Markwardt <[email protected]>
abg
approved these changes
Oct 16, 2023
ryanwittrup
approved these changes
Oct 16, 2023
Contributor
ryanwittrup
left a comment
ryanwittrup
left a comment
There was a problem hiding this comment.
looks good, confirming requirements are met
Contributor
|
@beyhan thanks for your help in reviewing this! With the two approvals from me and Andrew, is there anything else yall need? |
beyhan
approved these changes
Oct 18, 2023
rkoster
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on meeting requirements as defined in https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0006-approver-requirements.md
Reference previous PR #426
PR's increased to meet threshold of 20
PXC Release - 13
MySQL Monitoring Release - 4
CF Deployment - 1
Switchboard - 1
CLI Plugin - 1
Total = 20
Authored-by: Kevin Markwardt [email protected]