Skip to content

Conversation

@colins
Copy link
Member

@colins colins commented Sep 26, 2022

Remove 1 and add 5 approvers

The 3 new approvers are vmware employees with the following number of commits to the associated repos
2 new reviewers

Approvers:

  • name: Colin Shield
    github: colins
    45 commits

  • name: Kyle Ong
    github: ohkyle
    53 commits

  • name: Kim Basset
    github: kimago
    45 commits

Reviewers:

  • name: Kevin Markwardt
    github: kmarkwardt-vmware
    2 commits

  • name: Ryan Wittrup
    github: ryanwittrup
    16 commits

Remove:

  • name: Shaan Sapra
    github: ssapra

Co-authored-by: Colin Shield [email protected]
Co-authored-by: Andrew Garner [email protected]

Remove 1 and add 5 reviewers

Co-authored-by: Colin Shield <[email protected]>
Co-authored-by: Andrew Garner <[email protected]>
@rkoster
Copy link
Contributor

rkoster commented Sep 27, 2022

@colins Could you update the PR with the required proof of contributions as outlined here.
A great example of this can be seen here: #368

@rkoster rkoster self-requested a review September 27, 2022 15:02
Co-authored-by: Colin Shield <[email protected]>
Co-authored-by: Andrew Garner <[email protected]>
@rkoster rkoster requested a review from beyhan September 27, 2022 16:18
@beyhan beyhan merged commit 3c81bab into cloudfoundry:main Sep 28, 2022
kmarkwardt-vmware added a commit to kmarkwardt-vmware/community that referenced this pull request Oct 10, 2023
Based on meeting requirements as defined in https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0006-approver-requirements.md

Reference previous PR cloudfoundry#426

PR's increased to meet threshold of 20
PXC Release - 13
MySQL Monitoring Release - 4
CF Deployment - 1
Switchboard - 1
CLI Plugin - 1
Total = 20

Authored-by: Kevin Markwardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants