Skip to content

Conversation

@mkocher
Copy link
Member

@mkocher mkocher commented Jul 21, 2022

I'd like to be added as an approver in the Logging & Metrics working group.

@ameowlia would you be willing to nominate me?

Significant PR's Authored:

Reviewed:

Significant Slack Threads:

@ameowlia
Copy link
Member

ameowlia commented Jul 21, 2022

📝 According to the docs, to be nominated to approver you must be: "Nominated by a WG lead (with no objections from other leads)."

✨ As the WG lead for this area I heartily endorse this nomination.

👉 Tagging other leads. Please comment if you have any objection. If there are no objections within 1 week, then this PR can be merged. @cloudfoundry/toc , @cloudfoundry/wg-leads

@ameowlia ameowlia self-requested a review July 22, 2022 14:33
Copy link
Member

@ameowlia ameowlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkocher - you no longer need to change the cloudfoundry.yml file. That should happen automatically.

@mkocher mkocher force-pushed the logging-and-metrics-mkocher branch from 4252248 to c387488 Compare July 22, 2022 17:43
@mkocher
Copy link
Member Author

mkocher commented Jul 22, 2022

@mkocher - you no longer need to change the cloudfoundry.yml file. That should happen automatically.

Nice, adding it in two places didn't feel great. Updated the PR.

@emalm emalm added the wg label Jul 26, 2022
@emalm emalm dismissed ameowlia’s stale review August 30, 2022 14:17

Changes to the cloudfoundry.yml file have been removed.

@emalm emalm self-requested a review August 30, 2022 14:18
Copy link
Contributor

@emalm emalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the required approvals from other approvers in the area and has addressed the change requested from the WG lead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants