fix bug where active drains could become negative #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjamintf1
previously approved these changes
Jun 22, 2022
- active drains were only added when able to be connected to but removed when idle in regardless of connected states Signed-off-by: Ben Fuller <[email protected]> Signed-off-by: Matthew Kocher <[email protected]>
Benjamintf1
force-pushed
the
active-drains-bug
branch
from
b33cd40 to
f012747
Compare
Benjamintf1
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Fuller [email protected]
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch