Fixes concurrency bug in store test suite #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the Store creation logic in the tests so that the tests will never have multiple Stores accessing the same Metrics Registry at the same time. Prior to this commit, some tests (but most notably the "truncates older envelopes when max size is reached" test) will -when waiting to data values out of the Metrics Registry- will sometimes get values for the wrong Registry. Signed-off-by: Matthew Kocher <[email protected]>
ctlong
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the Store creation logic in the tests so that the
tests will never have multiple Stores accessing the same Metrics
Registry at the same time.
Prior to this commit, some tests (but most notably the "truncates older
envelopes when max size is reached" test) will -when waiting to data
values out of the Metrics Registry- will sometimes get values for the
wrong Registry.
Signed-off-by: Matthew Kocher [email protected]
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch