Skip to content

Fixes concurrency bug in store test suite #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Fixes concurrency bug in store test suite #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/internal/cache/store/store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ var _ = Describe("Store", func() {
BeforeEach(func() {
sp = newSpyPruner()
sm = testhelpers.NewMetricsRegistry()
s = store.NewStore(5, TruncationInterval, PrunesPerGC, sp, sm)
})

It("fetches data based on time and source ID", func() {
s = store.NewStore(5, TruncationInterval, PrunesPerGC, sp, sm)
e1 := buildEnvelope(1, "a")
e2 := buildEnvelope(2, "b")
e3 := buildEnvelope(3, "a")
Expand All @@ -57,6 +57,7 @@ var _ = Describe("Store", func() {
})

It("returns a maximum number of envelopes in ascending order", func() {
s = store.NewStore(5, TruncationInterval, PrunesPerGC, sp, sm)
e1 := buildEnvelope(1, "a")
e2 := buildEnvelope(2, "a")
e3 := buildEnvelope(3, "a")
Expand Down Expand Up @@ -185,6 +186,7 @@ var _ = Describe("Store", func() {
})

It("returns a maximum number of envelopes in descending order", func() {
s = store.NewStore(5, TruncationInterval, PrunesPerGC, sp, sm)
e1 := buildEnvelope(1, "a")
e2 := buildEnvelope(2, "a")
e3 := buildEnvelope(3, "a")
Expand All @@ -205,6 +207,7 @@ var _ = Describe("Store", func() {
})

It("increments the timestamp as necessary to prevent overwrites", func() {
s = store.NewStore(5, TruncationInterval, PrunesPerGC, sp, sm)
e1 := buildEnvelope(1, "a")
e2 := buildEnvelope(1, "a")
e3 := buildEnvelope(3, "a")
Expand All @@ -221,6 +224,7 @@ var _ = Describe("Store", func() {

DescribeTable("fetches data based on envelope type",
func(envelopeType logcache_v1.EnvelopeType, envelopeWrapper interface{}) {
s = store.NewStore(5, TruncationInterval, PrunesPerGC, sp, sm)
e1 := buildTypedEnvelope(1, "a", &loggregator_v2.Log{})
e2 := buildTypedEnvelope(2, "a", &loggregator_v2.Counter{})
e3 := buildTypedEnvelope(3, "a", &loggregator_v2.Gauge{})
Expand Down Expand Up @@ -253,6 +257,7 @@ var _ = Describe("Store", func() {

DescribeTable("fetches data based on metric name",
func(nameFilter, expectedName string) {
s = store.NewStore(5, TruncationInterval, PrunesPerGC, sp, sm)
filter := regexp.MustCompile(nameFilter)

e1 := buildTypedEnvelopeWithName(1, "counter-metric-name", &loggregator_v2.Counter{})
Expand Down Expand Up @@ -291,6 +296,7 @@ var _ = Describe("Store", func() {
)

It("is thread safe", func() {
s = store.NewStore(5, TruncationInterval, PrunesPerGC, sp, sm)
var wg sync.WaitGroup
wg.Add(2)
defer wg.Wait()
Expand Down