Gate pulling/syncing data from AWS in safegraph behind a flag in params #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Add 7-day average of each signal to Safegraph indicator"
…or"" This reverts commit e57673a.
…-indicators into fix_weekday
Contributor
|
Oh didn't even see I had a review requested on this one, sorry. I should add an inbox filter for github emails.... |
chinandrew
reviewed
Oct 27, 2020
chinandrew
reviewed
Oct 27, 2020
chinandrew
reviewed
Oct 27, 2020
chinandrew
reviewed
Oct 27, 2020
chinandrew
approved these changes
Oct 27, 2020
krivard
added a commit
that referenced
this pull request
Oct 28, 2020
Propagate #363 to safegraph (whoops)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
safegraph.run_module().safegraph.run_module()that skips over any interaction with AWS.safegraph_patternsto use similar variable naming and other paradigms.