Propagate #363 to safegraph (whoops) #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into deploy-usafacts
"Get up-to-date utils"
Diff uploads usafacts
- state_x -> state_y where x,y are in {code, id, name}
* update replace_geocode documentation to be clear about data columns * add test cases for renaming columns in replace_geocode * fix the state to state conversion dropped columns issue
Co-authored-by: chinandrew <[email protected]>
Add specific exceptions to bare excepts
Gate pulling/syncing data from AWS in safegraph behind a flag in params
Update safegraph patterns docstrings to pass pydocstyle
CHC SFTP Downloads
Update nchs docstrings to pass pydocstyle
Remove cds and emr_hosp directories
Stop lint recursion errors
Migrate indicators to a common `add_prefix()` library
chinandrew
approved these changes
Oct 28, 2020
Contributor
chinandrew
left a comment
chinandrew
left a comment
There was a problem hiding this comment.
so I still don't quite understand the deploy process yet, but I have no reason to suspect the changes will break as long as the new params file template is used.
Contributor
Author
|
Good catch; I would've missed that 😱 |
krivard
added a commit
that referenced
this pull request
Nov 5, 2020
krivard
added a commit
that referenced
this pull request
Nov 5, 2020
Fix production params file as identified in #392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should've gone in the other direction :(
@chinandrew you were approver on #363; apologies for the duplicate