Skip to content

Add specific exceptions to bare excepts #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2020
Merged

Add specific exceptions to bare excepts #391

merged 1 commit into from
Oct 28, 2020

Conversation

@chinandrew
Copy link
Contributor

@chinandrew chinandrew commented Oct 28, 2020

Summary of changes:

  • Add the expected exception to the except statement in the weekday.py files.

@chinandrew chinandrew mentioned this pull request Oct 28, 2020
Closed
@sgsmob sgsmob self-requested a review October 28, 2020 01:51
sgsmob
sgsmob approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@sgsmob sgsmob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krivard krivard merged commit 2f8d4df into main Oct 28, 2020
@krivard krivard deleted the add-exceptions branch February 9, 2021 18:54
@chinandrew chinandrew mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sgsmob sgsmob sgsmob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chinandrew @sgsmob @krivard