Skip to content

Add specific exceptions to bare excepts #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Add specific exceptions to bare excepts #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion changehc/delphi_changehc/weekday.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
# third party
import cvxpy as cp
import numpy as np
from cvxpy.error import SolverError

# first party
from .config import Config
Expand Down Expand Up @@ -83,7 +84,7 @@ def get_params(data):
try:
prob = cp.Problem(cp.Minimize(-ll + lmbda * penalty))
_ = prob.solve()
except:
except SolverError:
# If the magnitude of the objective function is too large, an error is
# thrown; Rescale the objective function
prob = cp.Problem(cp.Minimize((-ll + lmbda * penalty) / 1e5))
Expand Down
3 changes: 2 additions & 1 deletion claims_hosp/delphi_claims_hosp/weekday.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
# third party
import cvxpy as cp
import numpy as np
from cvxpy.error import SolverError

# first party
from .config import Config
Expand Down Expand Up @@ -83,7 +84,7 @@ def get_params(data):
try:
prob = cp.Problem(cp.Minimize(-ll + lmbda * penalty))
_ = prob.solve()
except:
except SolverError:
# If the magnitude of the objective function is too large, an error is
# thrown; Rescale the objective function
prob = cp.Problem(cp.Minimize((-ll + lmbda * penalty) / 1e5))
Expand Down
3 changes: 2 additions & 1 deletion emr_hosp/delphi_emr_hosp/weekday.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
# third party
import cvxpy as cp
import numpy as np
from cvxpy.error import SolverError

# first party
from .config import Config
Expand Down Expand Up @@ -83,7 +84,7 @@ def get_params(data):
try:
prob = cp.Problem(cp.Minimize(-ll + lmbda * penalty))
_ = prob.solve()
except:
except SolverError:
# If the magnitude of the objective function is too large, an error is
# thrown; Rescale the objective function
prob = cp.Problem(cp.Minimize((-ll + lmbda * penalty) / 1e5))
Expand Down