Skip to content

Remove unneeded try/except block #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2020
Merged

Remove unneeded try/except block #390

merged 1 commit into from
Nov 5, 2020

Conversation

@chinandrew
Copy link
Contributor

@chinandrew chinandrew commented Oct 27, 2020 •
edited
Loading

Tests pass without this, it's legacy code from when there used to be bugs.

closes #348

@chinandrew chinandrew mentioned this pull request Oct 27, 2020
Closed
@chinandrew chinandrew changed the title Remove unneeded bare except Remove unneeded try/except block Oct 28, 2020
krivard
krivard approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Should wait to merge until after #335.

@krivard krivard added the blocked This task is waiting for completion of another task label Oct 28, 2020
@krivard krivard merged commit f787b5b into main Nov 5, 2020
@krivard krivard removed the blocked This task is waiting for completion of another task label Nov 5, 2020
@krivard krivard deleted the remove-jhu-except branch February 9, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krivard krivard krivard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove bare excepts

3 participants

@chinandrew @krivard