Skip to content

doc: update readme with blog post feedback #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2024
Merged

doc: update readme with blog post feedback #249

merged 1 commit into from
Feb 23, 2024

Conversation

@dshemetov
Copy link
Contributor

Incorporating feedback from here.

@dshemetov dshemetov changed the base branch from dev to ds/cache February 16, 2024 18:02
@dshemetov dshemetov changed the base branch from ds/cache to dev February 16, 2024 18:03
dsweber2
dsweber2 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well; I'll assume it matches whatever feedback was given. It doesn't have typos or awkward phrasing as far as I can tell

@dshemetov dshemetov merged commit cd39d25 into dev Feb 23, 2024
@dshemetov dshemetov deleted the ds/readme branch February 23, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsweber2 dsweber2 dsweber2 approved these changes

@brookslogan brookslogan Awaiting requested review from brookslogan brookslogan is a code owner

@nmdefries nmdefries Awaiting requested review from nmdefries nmdefries is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dshemetov @dsweber2