Skip to content

Conversation

carlynvandyke
Copy link
Contributor

Forgotten blog post about epidatr that Dmitry drafted ages ago.

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit e8a906f
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/65cec368a3e4590008da0743
😎 Deploy Preview https://deploy-preview-912--cmu-delphi-main.netlify.app/blog/2023/09/27/new-package-released-epidatr-an-r-client-for-delphi-epidata-api
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the rendered html file... It was a pain to get it to work, but i should be able to easily do it again in the future!

pak::pkg_install("cmu-delphi/epidatr")
remotes::install_github("cmu-delphi/epidatr")
renv::install("cmu-delphi/epidatr")
\```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we gotta remove this backslash. ill do that and re-render the html file when i have a moment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember how i said above "I added the rendered html file... It was a pain to get it to work, but i should be able to easily do it again in the future!"? Well, i forgot how and didnt write it down, so i had to figure out how to do it again 😡 ... But for posterity, i downloaded and extracted a pandoc binary (from here), and added its bin/ directory to my PATH before executing Rscript -e 'blogdown::build_site(...

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take another look!


## Usage

```R
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code block seems to be automatically collapsed/folded/hidden, which is kinda silly because the article is for a package that people will use in their own code (and the resulting output block below it is not collapsed).

I think we can fix this by removing the R at the top of this block, or by replacing the R with {r class.source = 'fold-show'} as described here. The former is much simpler and i think i would go with that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this with no luck. I have a feeling that we're not really using blogdown, but instead just rendering html that is then passed through our Hugo blog's styling.

@melange396
Copy link
Contributor

@dshemetov, as the original author, do you have any comments on this?

@dshemetov
Copy link
Collaborator

I can fix those R blocks, I think, let me push a commit.

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some minor language tweaks + updates in response to changes in names of orgs & data sources.


```
library(epidatr)
# Obtain the smoothed covid-like illness (CLI) signal from the Facebook survey as it was on April 10, 2021 for the US

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Obtain the smoothed covid-like illness (CLI) signal from the Facebook survey as it was on April 10, 2021 for the US
# Obtain the smoothed covid-like illness (CLI) signal from the Delphi's US
# COVID-19 Trends and Impact Survey (CTIS), in partnership with Facebook, as it
# was reported on April 10, 2021, for the US at a national level

trying to get closer to the language here. Not sure about suggesting "Meta" above & "Facebook" here though

@melange396
Copy link
Contributor

Thanks @brookslogan ! It should be noted that many of your suggestions apply to text that appears to have come directly from https://cmu-delphi.github.io/epidatr/ , which i cannot find the source for (nor do i know who wrote it)... We may want to make similar edits there (wherever that may be).

@dshemetov
Copy link
Collaborator

Thanks @brookslogan, @melange396. Updated with above comments. I wrote the epidatr README and I'll move the updates from here to there next week.

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, lets get this thing released!!!

@melange396 melange396 merged commit 7a552fe into dev Feb 20, 2024
@melange396 melange396 deleted the epidatr-blog branch February 20, 2024 16:03
This was referenced Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants