-
Notifications
You must be signed in to change notification settings - Fork 7
Add epidatr blog post #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cmu-delphi-main ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the rendered html file... It was a pain to get it to work, but i should be able to easily do it again in the future!
Co-authored-by: melange396 <[email protected]>
Co-authored-by: melange396 <[email protected]>
Co-authored-by: melange396 <[email protected]>
Co-authored-by: melange396 <[email protected]>
Co-authored-by: melange396 <[email protected]>
content/blog/2023-09-27-epidatr.Rmd
Outdated
pak::pkg_install("cmu-delphi/epidatr") | ||
remotes::install_github("cmu-delphi/epidatr") | ||
renv::install("cmu-delphi/epidatr") | ||
\``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we gotta remove this backslash. ill do that and re-render the html file when i have a moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember how i said above "I added the rendered html file... It was a pain to get it to work, but i should be able to easily do it again in the future!"? Well, i forgot how and didnt write it down, so i had to figure out how to do it again 😡 ... But for posterity, i downloaded and extracted a pandoc binary (from here), and added its bin/
directory to my PATH
before executing Rscript -e 'blogdown::build_site(...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please take another look!
content/blog/2023-09-27-epidatr.Rmd
Outdated
|
||
## Usage | ||
|
||
```R |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code block seems to be automatically collapsed/folded/hidden, which is kinda silly because the article is for a package that people will use in their own code (and the resulting output block below it is not collapsed).
I think we can fix this by removing the R
at the top of this block, or by replacing the R
with {r class.source = 'fold-show'}
as described here. The former is much simpler and i think i would go with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried this with no luck. I have a feeling that we're not really using blogdown, but instead just rendering html that is then passed through our Hugo blog's styling.
@dshemetov, as the original author, do you have any comments on this? |
Co-authored-by: melange396 <[email protected]>
I can fix those R blocks, I think, let me push a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some minor language tweaks + updates in response to changes in names of orgs & data sources.
content/blog/2023-09-27-epidatr.Rmd
Outdated
|
||
``` | ||
library(epidatr) | ||
# Obtain the smoothed covid-like illness (CLI) signal from the Facebook survey as it was on April 10, 2021 for the US |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Obtain the smoothed covid-like illness (CLI) signal from the Facebook survey as it was on April 10, 2021 for the US | |
# Obtain the smoothed covid-like illness (CLI) signal from the Delphi's US | |
# COVID-19 Trends and Impact Survey (CTIS), in partnership with Facebook, as it | |
# was reported on April 10, 2021, for the US at a national level |
trying to get closer to the language here. Not sure about suggesting "Meta" above & "Facebook" here though
Thanks @brookslogan ! It should be noted that many of your suggestions apply to text that appears to have come directly from https://cmu-delphi.github.io/epidatr/ , which i cannot find the source for (nor do i know who wrote it)... We may want to make similar edits there (wherever that may be). |
Thanks @brookslogan, @melange396. Updated with above comments. I wrote the epidatr README and I'll move the updates from here to there next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, lets get this thing released!!!
Forgotten blog post about
epidatr
that Dmitry drafted ages ago.