-
Notifications
You must be signed in to change notification settings - Fork 39
Add job id to result set footer #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: worksofliam <[email protected]>
|
👋 A new build is available for this PR based on 7978248. |
|
Another idea, perhaps requiring its own PR, would be to add a span to the footer, between the status and the job name, with the caption 'SQL'. Hovering over it would display the formatted SQL that produced the results. Edited: Alternate idea would be to have the new span have the caption 'Details', that when hovered over, shows the job name and SQL. This approach de-clutters the footer, and makes adding details later more straightforward. |
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
|
👋 A new build is available for this PR based on 39c6097. |
I like this idea a lot, but it should be a separate PR. Also, I don't know if from a web view we get the same cool hover support like we do with tree views. |
Signed-off-by: worksofliam <[email protected]>
|
👋 A new build is available for this PR based on 66d6118. |
davecharron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Send it.
|
👋 A new build is available for this PR based on 0def90d. |

Simply adds the executing job id to the footer of the result set.