Skip to content

Conversation

@worksofliam
Copy link
Member

@worksofliam worksofliam commented Apr 2, 2024

Simply adds the executing job id to the footer of the result set.

image

@github-actions
Copy link

github-actions bot commented Apr 2, 2024

👋 A new build is available for this PR based on 7978248.

@worksofliam worksofliam linked an issue Apr 2, 2024 that may be closed by this pull request
@davecharron
Copy link
Collaborator

I wonder if the job name text should be slightly less prominent than the results status.
Perhaps font that is grey and/or slightly smaller size.
The way it is displayed in the SQL Job Manager.
image

@davecharron
Copy link
Collaborator

davecharron commented Apr 4, 2024

Another idea, perhaps requiring its own PR, would be to add a span to the footer, between the status and the job name, with the caption 'SQL'. Hovering over it would display the formatted SQL that produced the results.

Edited: Alternate idea would be to have the new span have the caption 'Details', that when hovered over, shows the job name and SQL. This approach de-clutters the footer, and makes adding details later more straightforward.

@worksofliam worksofliam self-assigned this Apr 8, 2024
@worksofliam worksofliam requested a review from davecharron April 15, 2024 13:47
@github-actions
Copy link

👋 A new build is available for this PR based on 39c6097.

@worksofliam
Copy link
Member Author

@davecharron

Edited: Alternate idea would be to have the new span have the caption 'Details', that when hovered over, shows the job name and SQL. This approach de-clutters the footer, and makes adding details later more straightforward.

I like this idea a lot, but it should be a separate PR. Also, I don't know if from a web view we get the same cool hover support like we do with tree views.

Signed-off-by: worksofliam <[email protected]>
@worksofliam worksofliam requested a review from davecharron April 15, 2024 17:07
@github-actions
Copy link

👋 A new build is available for this PR based on 66d6118.

Copy link
Collaborator

@davecharron davecharron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it.

@github-actions
Copy link

👋 A new build is available for this PR based on 0def90d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL results view should include which job the statement was run in

3 participants