Skip to content

Conversation

@davecharron
Copy link
Collaborator

@davecharron davecharron commented Apr 17, 2024

Fix a bug introduced by PR #224

A non-existent variable is referenced in the javascript in the generated HTML for displaying results.

Change to use the correct variable.

Fixes issue #228

@davecharron davecharron requested a review from worksofliam April 17, 2024 21:16
@github-actions
Copy link

👋 A new build is available for this PR based on c178c23.

@davecharron davecharron linked an issue Apr 17, 2024 that may be closed by this pull request
@davecharron davecharron self-assigned this Apr 17, 2024
@davecharron davecharron added the ready The tag should be taken off if it is being worked on, or if a review fails label Apr 17, 2024
Copy link
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. Good find!

@worksofliam worksofliam merged commit 4e3be88 into main Apr 18, 2024
@davecharron davecharron deleted the fix/job_id_in_result_set_footer branch April 18, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready The tag should be taken off if it is being worked on, or if a review fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A bug was introduced by PR #224

3 participants