Description Edit Button bug fixed #6421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit9625
approved these changes
Sep 10, 2025
Collaborator
rohit9625
left a comment
rohit9625
left a comment
There was a problem hiding this comment.
Works great, thanks @LeopoldoDelgadillo
Screen_recording_20250910_074852.webm
Ready to merge, @nicolas-raoul
nicolas-raoul
approved these changes
Sep 10, 2025
Member
nicolas-raoul
left a comment
nicolas-raoul
left a comment
There was a problem hiding this comment.
Thanks a lot Leopoldo and sorry for the delay!
|
✅ Generated APK variants! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6407
What changes did you make and why?
When the user clicks on the description edit button in a contribution, the button changes to the progress bar icon and then it goes into the edit menu. When going back to the contribution either with submit or cancel, onResume flagged the progress bar icon as GONE but there was no call to flag the description edit button back to VISIBLE, so the only required change was to add the VISIBLE flag to the description edit button inside the onResume function.
Tests performed
Tested ProdDebug on CUBOT X70 (Android 13) with API level 35.