eslint config updates #1706
Merged
eslint config updates #1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@typescript-eslint/ban-types is deprecated in v8. no-dupe-class-members isn't recommended, it's redundant with the typescript compiler. letting naming-convention lint run on this file doesn't produce any errors.
including JS files in a tsconfig was a strange hack that won't even work anymore, it looks like @typescript-eslint/parser v8 refuses to acknowledge the .js files. move tsconfig.workers.json and let autodetection magic work.
dynst
force-pushed
the
eslint-ts8-prep
branch
2 times, most recently
from
8f399ec to
4bfb975
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes the tsconfig.eslint.json files from #788. JavaScript files shouldn't be in a tsconfig.json and typescript-eslint v8 will pretend they aren't there (leading to errors).
.js files should use the default
"espree"parser instead. Since it's not a TypeScript parser, a modernecmaVersionis needed to enable parsing this syntax.cosmjs/packages/ledger-amino/demo/node.js
Line 9 in 7cc6752
And remove references to these:
https://typescript-eslint.io/rules/no-dupe-class-members
https://typescript-eslint.io/rules/ban-types/