typescript eslint 8.x #1749
Merged
typescript eslint 8.x #1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Wait, cosmjs/packages/json-rpc/src/parse.ts Line 40 in 2300145 |
v8 of the plugin has no false positives.
Member
Contributor
Author
|
Fantastic, with that merged, this PR can pass CI now. It just needs to be triggered to re-run the failing job. https://github.com/cosmos/cosmjs/actions/runs/16606765416/job/46980448301?pr=1749 |
Member
|
Re-run did not help. I think you have to rebase this to latest main to test the update from #1751. |
webmaster128
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #1706 #1718 #1724 and #1740 done, there's just 1 new lint that needs turning off and 1 that got renamed.
https://typescript-eslint.io/rules/prefer-promise-reject-errors/
https://typescript-eslint.io/rules/no-empty-interface/