Accessibility improvements #978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a little part of the overall work, but I'd like to receive a feedback before continuing. I'd also like to know which level of Accessibility the website should at least support, since, in some situations, this may also have an impact on the design. My idea is to keep the WCAG 2.2, Level AA. This should be a good trade-off between simplicity for development and a better UX for people with disabilities. Moreover, this should make the website conformant with the EAA (EN 301 549).
The
header-ctalinks had "aria-label" attributes that essentially repeated what the information that can be retrieved by the text node. Also, the first link had a mismatch between what there was in thearia-labelattribute ("Documentation") and what there's in the text node ("Get Started").The
menu-barunordered list heavily uses theroleattribute. However, this doesn't seem necessary, since the semantics is already provided by the DOM. If the intention was to remove the semantics of<li>to replace it with<a>, I think the issue is more related to this article.The
role="navigation"attribute was used in a<nav>tag, even if this is already provided by the tag itself. Indeed, the<nav>tag has implicitly the navigation role. If the intention was to keep it for compatibility with browsers that doesn't support HTML5, it should be at least applied consistently.About the
starsection, there's already a text node, which says "Give us a Star on GitHub", and therefore the use of anaria-labelattribute that essentially reports the same isn't useful.Finally, the SVG code in the
logo.hbsfile wasn't hidden with thearia-hiddenattribute.