Skip to content

fix(ci,style): improve asset copying and enhance UI contrast for docs site #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 29, 2025
Merged

fix(ci,style): improve asset copying and enhance UI contrast for docs site #979

merged 7 commits into from
Aug 29, 2025

Conversation

@julioest
Copy link
Contributor

@julioest julioest commented Aug 27, 2025 •
edited
Loading

  • fix: copy website assets properly in CI
  • chore: remove unnecessary footer content
  • style: update doc link colors in vars.css for better contrast
  • style: refine color variables and update styles for better contrast
  • style: update pagination colors for improved visibility
  • style: update code highlight and toc colors for contrast
  • style: change stroke color in home-o.svg to white

@julioest julioest requested a review from alandefreitas August 27, 2025 18:54
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://979.mrdocs.prtest2.cppalliance.org/index.html

@alandefreitas
Copy link
Collaborator

This is undoing some of the work from #978. Is that on purpose?

@alandefreitas
Copy link
Collaborator

Actually, index.html shouldn't even be in the repo. This is an artifact. When did that happen? That has to go.

@julioest
Copy link
Contributor Author

I'll add that to the gitignore

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://979.mrdocs.prtest2.cppalliance.org/index.html

1 similar comment
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://979.mrdocs.prtest2.cppalliance.org/index.html

@julioest julioest force-pushed the fix/copy-websites-assets-ci branch 2 times, most recently from 9a9e639 to af91331 Compare August 27, 2025 20:22
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://979.mrdocs.prtest2.cppalliance.org/index.html

2 similar comments
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://979.mrdocs.prtest2.cppalliance.org/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://979.mrdocs.prtest2.cppalliance.org/index.html

@alandefreitas
Copy link
Collaborator

We could remove or comment out this whole footer

image

@alandefreitas
Copy link
Collaborator

The links and code blocks are very hard to read.

image image

@alandefreitas
Copy link
Collaborator

I'll add that to the gitignore

Already did in some other PR just in case.

@alandefreitas
Copy link
Collaborator

Let me know when this is good to go. :)

@julioest
fix: copy website assets properly in CI
635de08 
- Inline logo styles to resolve build dependencies
- Update CI workflow for correct asset copying
- Generate landing page website with all required styles
@julioest julioest force-pushed the fix/copy-websites-assets-ci branch from 6428fb7 to ea5d3f4 Compare August 29, 2025 15:09
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://979.mrdocs.prtest2.cppalliance.org/index.html

@julioest
Copy link
Contributor Author

julioest commented Aug 29, 2025 •
edited
Loading

Okay! So, made those changes addressing the color contrast. I'm going to clean up the commits, then it's good to go

Edit: ok, done.

@julioest julioest force-pushed the fix/copy-websites-assets-ci branch from 7b18692 to 811d516 Compare August 29, 2025 16:27
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://979.mrdocs.prtest2.cppalliance.org/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://979.mrdocs.prtest2.cppalliance.org/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://979.mrdocs.prtest2.cppalliance.org/index.html

@julioest julioest changed the title fix: copy website assets properly in CI fix(ci,style): improve asset copying and enhance UI contrast for docs site Aug 29, 2025
@julioest julioest merged commit 35e14c9 into cppalliance:develop Aug 29, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alandefreitas alandefreitas Awaiting requested review from alandefreitas

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@julioest @cppalliance-bot @alandefreitas