singlemount: create metadata dir only when running singlemount-runner #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The directory was created in all cvmfs-csi components (including controllerplugin), because the MkdirAll was called in init() function. This breaks deployments that don't run controllerplugin as root. It doesn't have perms to create the directory, and init() exits with panic(). This commit fixes that by separating the directory creation into another function.
gman0
force-pushed
the
singlemount-create-dir-fix
branch
from
6973055 to
463a16d
Compare
gman0
added a commit
to gman0/cvmfs-csi
that referenced
this pull request
Oct 6, 2023
The directory was created in all cvmfs-csi components (including controllerplugin), because the MkdirAll was called in init() function. This breaks deployments that don't run controllerplugin as root. It doesn't have perms to create the directory, and init() exits with panic(). This commit fixes that by separating the directory creation into another function. Cherry-pick cabfc11 (cvmfs-contrib#127)
gman0
added a commit
that referenced
this pull request
Oct 6, 2023
(Backport #127) sharedmount: create metadata dir only when running sharedmount-runner
gman0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directory was created in all cvmfs-csi components (including controllerplugin), because the MkdirAll was called in init() function. This breaks deployments that don't run controllerplugin as root. It doesn't have perms to create the directory, and init() exits with panic().
This PR fixes that by separating the directory creation into another function.