Skip to content

Conversation

jdye64
Copy link
Collaborator

@jdye64 jdye64 commented Oct 5, 2021

Currently data is persisted into memory when create_table is invoked. Instead this PR will set the default for persist to False which will prevent that from happening.

This Closes: #218

charlesbluca and others added 2 commits September 24, 2021 11:43
* Add dask-cudf tests with GPU marker

* Change --gpu option to --rungpu

* xfail GPU table creation from memory
@charlesbluca
Copy link
Collaborator

Now that #240 is merged, you should revert efa492f, as it retains some bugs from the initial setup of gpuCI

Copy link
Collaborator

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the doctstring in the params section here as well:

persist (:obj:`bool`): Only used when passing a string into the ``input`` parameter.

@jdye64
Copy link
Collaborator Author

jdye64 commented Oct 12, 2021

Could you update the doctstring in the params section here as well:

persist (:obj:`bool`): Only used when passing a string into the ``input`` parameter.

Yep, just flipped around the values from False -> True and off->on since the rest of the doc string is still valid.

@jdye64
Copy link
Collaborator Author

jdye64 commented Oct 12, 2021

rerun tests

Copy link
Collaborator

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jdye64! Will merge in once tests finish up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider persist=False as default when creating table from DataFrame

3 participants