This repository was archived by the owner on Aug 29, 2024. It is now read-only.
Do not persist data to memory by default when creating tables #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally I'd like to hold off on merging until CI tests are up and we can test the impact of these changes on the PR. Does that work for others? |
|
Sounds perfectly logical to me
…On Mon, Sep 27, 2021 at 2:40 PM Ayush Dattagupta ***@***.***> wrote:
Ideally I'd like to hold off on merging until CI tests are up and we can
test the impact of these changes on the PR. Does that work for others?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQHLAZBOCWP3FS6XTDYDWLUEC3B5ANCNFSM5EWU5FKQ>
.
|
|
@jdye64 this went in PR ( dask-contrib#245 ), right? If so, is this ok to close? |
|
Correct. It is good to close |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently data is persisted into memory when
create_tableis invoked. Instead this PR will set the default for persist to False which will prevent that from happening.This Closes: dask-contrib#218