CNDB-15435: Don't purge rows in the replicas with bytes-sized paging #2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
adelapena
force-pushed
the
CNDB-15435-main-dont-purge
branch
from
f2925cb to
5f39850
Compare
adelapena
changed the title
|
✔️ Build ds-cassandra-pr-gate/PR-2009 approved by ButlerApproved by Butler |
pkolaczk
reviewed
Sep 23, 2025
Comment on lines
+452
to
+455
| // We only purge rows before sending them to the coordinator if the limit isn't in bytes. | ||
| // Otherwise, the replica can send rows with a size lower than the requested page size, | ||
| // making the coordinator think that there is no more data and wrongly end paging. | ||
| // See CNDB-15435 for further details. |
There was a problem hiding this comment.
Indeed it does, both PRs reduce protection against tombstone overwhelming.
pkolaczk
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
Approving because correctness > performance.
However, I don't like the fact it introduces yet another special case (purging works in one case, but not in another) and I agree that a flag-based approach (passing information to the coordinator) would be less fragile.
|
Closed in favor of #2010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't purge rows in the replicas when we are using bytes-sized limits. Otherwise, the coordinator can get rows with a size lower than the requested page size and think that there is no more data.